Skip to content
Snippets Groups Projects
Commit 16b03678 authored by Paolo 'Blaisorblade' Giarrusso's avatar Paolo 'Blaisorblade' Giarrusso Committed by Linus Torvalds
Browse files

[PATCH] uml: avoid already done dirtying


The PTE returned from handle_mm_fault is already marked as dirty and accessed
if needed.

Also, since this is not set with set_pte() (which sets NEWPAGE and NEWPROT as
needed), this wouldn't work anyway.

This version has been updated and fixed, thanks to some feedback from Jeff Dike.

Signed-off-by: default avatarPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d129f312
No related branches found
No related tags found
No related merge requests found
...@@ -85,8 +85,7 @@ survive: ...@@ -85,8 +85,7 @@ survive:
pte = pte_offset_kernel(pmd, address); pte = pte_offset_kernel(pmd, address);
} while(!pte_present(*pte)); } while(!pte_present(*pte));
err = 0; err = 0;
*pte = pte_mkyoung(*pte); WARN_ON(!pte_young(*pte) || (is_write && !pte_dirty(*pte)));
if(pte_write(*pte)) *pte = pte_mkdirty(*pte);
flush_tlb_page(vma, address); flush_tlb_page(vma, address);
out: out:
up_read(&mm->mmap_sem); up_read(&mm->mmap_sem);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment