Commit 09034cb7 authored by Johannes Berg's avatar Johannes Berg Committed by Reinette Chatre

iwlwifi: return ucode errors from station management

When station management calls to ucode return
an error we could previously do nothing, but
now that almost all calls are synchronous we
can actually let the error bubble up. Use EIO
as the error as it best indicates a problem
with the device.
Signed-off-by: default avatarJohannes Berg <>
Signed-off-by: default avatarReinette Chatre <>
parent e666674e
......@@ -55,18 +55,19 @@ static void iwl_sta_ucode_activate(struct iwl_priv *priv, u8 sta_id)
static void iwl_process_add_sta_resp(struct iwl_priv *priv,
struct iwl_addsta_cmd *addsta,
struct iwl_rx_packet *pkt,
bool sync)
static int iwl_process_add_sta_resp(struct iwl_priv *priv,
struct iwl_addsta_cmd *addsta,
struct iwl_rx_packet *pkt,
bool sync)
u8 sta_id = addsta->sta.sta_id;
unsigned long flags;
int ret = -EIO;
if (pkt->hdr.flags & IWL_CMD_FAILED_MSK) {
IWL_ERR(priv, "Bad return from REPLY_ADD_STA (0x%08X)\n",
return ret;
IWL_DEBUG_INFO(priv, "Processing response for adding station %u\n",
......@@ -78,6 +79,7 @@ static void iwl_process_add_sta_resp(struct iwl_priv *priv,
iwl_sta_ucode_activate(priv, sta_id);
ret = 0;
IWL_ERR(priv, "Adding station %d failed, no room in table.\n",
......@@ -115,6 +117,8 @@ static void iwl_process_add_sta_resp(struct iwl_priv *priv,
STA_CONTROL_MODIFY_MSK ? "Modified" : "Added",
spin_unlock_irqrestore(&priv->sta_lock, flags);
return ret;
static void iwl_add_sta_callback(struct iwl_priv *priv,
......@@ -159,7 +163,7 @@ int iwl_send_add_sta(struct iwl_priv *priv,
if (ret == 0) {
pkt = (struct iwl_rx_packet *)cmd.reply_page;
iwl_process_add_sta_resp(priv, sta, pkt, true);
ret = iwl_process_add_sta_resp(priv, sta, pkt, true);
iwl_free_pages(priv, cmd.reply_page);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment