Commit 02c608c1 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds

documentation: atomic_add_unless() doesn't imply mb() on failure

(sorry for being offtpoic, but while experts are here...)

A "typical" implementation of atomic_add_unless() can return 0 immediately
after the first atomic_read() (before doing cmpxchg). In that case it doesn't
provide any barrier semantics. See include/asm-ia64/atomic.h as an example.

We should either change the implementation, or fix the docs.
Signed-off-by: default avatarOleg Nesterov <>
Acked-by: default avatarNick Piggin <>
Signed-off-by: default avatarLinus Torvalds <>
parent 2dda81ca
......@@ -186,7 +186,8 @@ If the atomic value v is not equal to u, this function adds a to v, and
returns non zero. If v is equal to u then it returns zero. This is done as
an atomic operation.
atomic_add_unless requires explicit memory barriers around the operation.
atomic_add_unless requires explicit memory barriers around the operation
unless it fails (returns 0).
atomic_inc_not_zero, equivalent to atomic_add_unless(v, 1, 0)
......@@ -1493,7 +1493,7 @@ explicit lock operations, described later). These include:
atomic_add_unless(); /* when succeeds (returns 1) */
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment