Skip to content
  • Richard Genoud's avatar
    BUG: atmel_serial: Interrupts not disabled on close · 307475da
    Richard Genoud authored
    commit 0ae9fdefb6c37237d826d6195e27810ffcc0b6e0 upstream.
    
    Since commit 18dfef9c ("serial: atmel: convert to irq handling
    provided mctrl-gpio"), interrupts from GPIOs are not disabled any more
    when the serial port is closed, leading to an oops when the one of the
    input pin is toggled (CTS/DSR/DCD/RNG).
    
    This is only the case if those pins are used as GPIOs, i.e. declared
    like that:
    usart1: serial@f8020000 {
            /* CTS and DTS will be handled by GPIO */
            status = "okay";
            rts-gpios = <&pioB 17 GPIO_ACTIVE_LOW>;
            cts-gpios = <&pioB 16 GPIO_ACTIVE_LOW>;
            dtr-gpios = <&pioB 14 GPIO_ACTIVE_LOW>;
            dsr-gpios = <&pioC 31 GPIO_ACTIVE_LOW>;
            rng-gpios = <&pioB 12 GPIO_ACTIVE_LOW>;
            dcd-gpios = <&pioB 15 GPIO_ACTIVE_LOW>;
    };
    
    That's because modem interrupts used to be freed in atmel_shutdown().
    After commit 18dfef9c
    
     ("serial: atmel: convert to irq handling
    provided mctrl-gpio"), this code was just removed.
    Calling atmel_disable_ms() disables the interrupts and everything works
    fine again.
    
    Tested on at91sam9g35-cm
    
    (This patch doesn't apply on -stable kernels, fixes for 4.4 and 4.7 will
    be sent after this one is applied.)
    
    Signed-off-by: default avatarRichard Genoud <richard.genoud@gmail.com>
    Fixes: 18dfef9c
    
     ("serial: atmel: convert to irq handling provided mctrl-gpio")
    Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
    Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    307475da