• Tejun Heo's avatar
    [SCSI] sd,sr: kill compat SDEV_MEDIA_CHANGE event · f4013c38
    Tejun Heo authored
    SDEV_MEDIA_CHANGE event was first added by commit a341cd0f (SCSI: add
    asynchronous event notification API) for SATA AN support and then
    extended to cover generic media change events by commit 285e9670
    ([SCSI] sr,sd: send media state change modification events).
    This event was mapped to block device in userland with all properties
    stripped to simulate CHANGE event on the block device, which, in turn,
    was used to trigger further userspace action on media change.
    The recent addition of disk event framework kept this event for
    backward compatibility but it turns out to be unnecessary and causes
    erratic and inefficient behavior.  The new disk event generates proper
    events on the block devices and the compat events are mapped to block
    device with all properties stripped, so the block device ends up
    generating multiple duplicate events for single actual event.
    This patch removes the compat event generation from both sr and sd as
    suggested by Kay Sievers.  Both existing and newer versions of udev
    and the associated tools will behave better with the removal of these
    events as they from the beginning were expecting events on the block
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Acked-by: default avatarKay Sievers <kay.sievers@vrfy.org>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
sd.c 72.1 KB