Skip to content
  • Jens Axboe's avatar
    [PATCH] cfq-iosched: merging problem · ec8acb69
    Jens Axboe authored
    
    
    Two issues:
    
    - The final return 1 should be a return 0, otherwise comparing cfqq is
      a noop.
    
    - bio_sync() only checks the sync flag, while rq_is_sync() checks both
      for READ and sync. The latter is what we want. Expand the bio check
      to include reads, and relax the restriction to allow merging of async
      io into sync requests.
    
    In the future we want to clean up the SYNC logic, right now it means
    both sync request (such as READ and O_DIRECT WRITE) and unplug-on-issue.
    Leave that for later.
    
    Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    ec8acb69