Skip to content
  • Arnd Bergmann's avatar
    usb: dwc2: fix regression on big-endian PowerPC/ARM systems · 23e34392
    Arnd Bergmann authored
    A patch that went into Linux-4.4 to fix big-endian mode on a Lantiq
    MIPS system unfortunately broke big-endian operation on PowerPC
    APM82181 as reported by Christian Lamparter, and likely other
    systems.
    
    It actually introduced multiple issues:
    
    - it broke big-endian ARM kernels: any machine that was working
      correctly with a little-endian kernel is no longer using byteswaps
      on big-endian kernels, which clearly breaks them.
    - On PowerPC the same thing must be true: if it was working before,
      using big-endian kernels is now broken. Unlike ARM, 32-bit PowerPC
      usually uses big-endian kernels, so they are likely all broken.
    - The barrier for dwc2_writel is on the wrong side of the __raw_writel(),
      so the MMIO no longer synchronizes with DMA operations.
    - On architectures that require specific CPU instructions for MMIO
      access, using the __raw_ variant may turn this into a pointer
      dereference that does not have the same effect as the readl/writel.
    
    This patch is a simple revert for all architectures other than MIPS,
    in the hope that we can more easily backport it to fix the regression
    on PowerPC and ARM systems without breaking the Lantiq system again.
    
    We should follow this up with a more elaborate change to add runtime
    detection of endianness, to make sure it also works on all other
    combinations of architectures and implementations of the usb-dwc2
    device. That patch however will be fairly large and not appropriate
    for backports to stable kernels.
    
    Felipe suggested a different approach, using an endianness switching
    register to always put the device into LE mode, but unfortunately
    the dwc2 hardware does not provide a generic way to do that. Also,
    I see no practical way of addressing the problem more generally by
    patching architecture specific code on MIPS.
    
    Fixes: 95c8bc36
    
     ("usb: dwc2: Use platform endianness when accessing registers")
    Acked-by: default avatarJohn Youn <johnyoun@synopsys.com>
    Tested-by: default avatarChristian Lamparter <chunkeey@googlemail.com>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
    23e34392