Skip to content
  • Suzuki K. Poulose's avatar
    ARM: perf: reject groups spanning multiple hardware PMUs · e429817b
    Suzuki K. Poulose authored
    
    
    The perf core implicitly rejects events spanning multiple HW PMUs, as in
    these cases the event->ctx will differ. However this validation is
    performed after pmu::event_init() is called in perf_init_event(), and
    thus pmu::event_init() may be called with a group leader from a
    different HW PMU.
    
    The ARM PMU driver does not take this fact into account, and when
    validating groups assumes that it can call to_arm_pmu(event->pmu) for
    any HW event. When the event in question is from another HW PMU this is
    wrong, and results in dereferencing garbage.
    
    This patch updates the ARM PMU driver to first test for and reject
    events from other PMUs, moving the to_arm_pmu and related logic after
    this test. Fixes a crash triggered by perf_fuzzer on Linux-4.0-rc2, with
    a CCI PMU present:
    
     ---
    CPU: 0 PID: 1527 Comm: perf_fuzzer Not tainted 4.0.0-rc2 #57
    Hardware name: ARM-Versatile Express
    task: bd8484c0 ti: be676000 task.ti: be676000
    PC is at 0xbf1bbc90
    LR is at validate_event+0x34/0x5c
    pc : [<bf1bbc90>]    lr : [<80016060>]    psr: 00000013
    ...
    [<80016060>] (validate_event) from [<80016198>] (validate_group+0x28/0x90)
    [<80016198>] (validate_group) from [<80016398>] (armpmu_event_init+0x150/0x218)
    [<80016398>] (armpmu_event_init) from [<800882e4>] (perf_try_init_event+0x30/0x48)
    [<800882e4>] (perf_try_init_event) from [<8008f544>] (perf_init_event+0x5c/0xf4)
    [<8008f544>] (perf_init_event) from [<8008f8a8>] (perf_event_alloc+0x2cc/0x35c)
    [<8008f8a8>] (perf_event_alloc) from [<8009015c>] (SyS_perf_event_open+0x498/0xa70)
    [<8009015c>] (SyS_perf_event_open) from [<8000e420>] (ret_fast_syscall+0x0/0x34)
    Code: bf1be000 bf1bb380 802a2664 00000000 (00000002)
    ---[ end trace 01aff0ff00926a0a ]---
    
    Also cleans up the code to use the arm_pmu only when we know that
    we are dealing with an arm pmu event.
    
    Cc: Will Deacon <will.deacon@arm.com>
    Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
    Acked-by: default avatarPeter Ziljstra (Intel) <peterz@infradead.org>
    Signed-off-by: default avatarSuzuki K. Poulose <suzuki.poulose@arm.com>
    Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
    e429817b