Skip to content
  • Arjan van de Ven's avatar
    perf: avoid structure size confusion by using a fixed size · dfe5a504
    Arjan van de Ven authored
    
    
    for some reason, this structure gets compiled as 36 bytes in some files
    (the ones that alloacte it) but 40 bytes in others (the ones that use it).
    The cause is an off_t type that gets a different size in different
    compilation units for some yet-to-be-explained reason.
    
    But the effect is disasterous; the size/offset members of the struct
    are at different offsets, and result in mostly complete garbage.
    The parser in perf is so robust that this all gets hidden, and after
    skipping an certain amount of samples, it recovers.... so this bug
    is not normally noticed.
    
    .... except when you want every sample to be exact.
    
    Fix this by just using an explicitly sized type.
    
    Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
    Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    LKML-Reference: <4A655917.9080504@linux.intel.com>
    dfe5a504