Skip to content
  • Hugh Dickins's avatar
    ksm: fix endless loop on oom · d952b791
    Hugh Dickins authored
    
    
    break_ksm has been looping endlessly ignoring VM_FAULT_OOM: that should
    only be a problem for ksmd when a memory control group imposes limits
    (normally the OOM killer will kill others with an mm until it succeeds);
    but in general (especially for MADV_UNMERGEABLE and KSM_RUN_UNMERGE) we
    do need to route the error (or kill) back to the caller (or sighandling).
    
    Test signal_pending in unmerge_ksm_pages, which could be a lengthy
    procedure if it has to spill into swap: returning -ERESTARTSYS so that
    trivial signals will restart but fatals will terminate (is that right?
    we do different things in different places in mm, none exactly this).
    
    unmerge_and_remove_all_rmap_items was forgetting to lock when going
    down the mm_list: fix that.  Whether it's successful or not, reset
    ksm_scan cursor to head; but only if it's successful, reset seqnr
    (shown in full_scans) - page counts will have gone down to zero.
    
    This patch leaves a significant OOM deadlock, but it's a good step
    on the way, and that deadlock is fixed in a subsequent patch.
    
    Signed-off-by: default avatarHugh Dickins <hugh.dickins@tiscali.co.uk>
    Acked-by: default avatarIzik Eidus <ieidus@redhat.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    d952b791