Skip to content
  • Satyam Sharma's avatar
    [NET] netconsole: Simplify boot/module option setup logic · d2b60881
    Satyam Sharma authored
    
    
    Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.
    
    Presently, boot/module parameters are set up quite differently for the case of
    built-in netconsole (__setup() -> obsolete_checksetup() ->
    netpoll_parse_options() -> strlen(config) == 0 in init_netconsole()) vs
    modular netconsole (module_param_string() -> string copied to the config
    variable -> strlen(config) != 0 init_netconsole() -> netpoll_parse_options()).
    
    This patch makes both of them similar by doing exactly the equivalent of a
    module_param_string() in option_setup() also -- just copying the param string
    passed from the kernel command line into "config" variable.  So,
    strlen(config) != 0 in both cases, and netpoll_parse_options() is always
    called from init_netconsole(), thus making the setup logic for both cases
    similar.
    
    Now, option_setup() is only ever called / used for the built-in case, so we
    put it inside a #ifndef MODULE, otherwise gcc will complain about
    option_setup() being "defined but not used".  Also, the "configured" variable
    is redundant with this patch and hence removed.
    
    Signed-off-by: default avatarSatyam Sharma <satyam@infradead.org>
    Signed-off-by: default avatarKeiichi Kii <k-keiichi@bx.jp.nec.com>
    Acked-by: default avatarMatt Mackall <mpm@selenic.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d2b60881