• Borislav Petkov's avatar
    ide-cd: convert to using generic sense request · c457ce87
    Borislav Petkov authored
    Preallocate a sense request in the ->do_request method and reinitialize
    it only on demand, in case it's been consumed in the IRQ handler path.
    The reason for this is that we don't want to be mapping rq to bio in
    the IRQ path and introduce all kinds of unnecessary hacks to the block
    tj: * Both user and kernel PC requests expect sense data to be stored
          in separate storage other than drive->sense_data.  Copy sense
          data to rq->sense on completion if rq->sense is not NULL.  This
          fixes bogus sense data on PC requests.
    As a result, remove cdrom_queue_request_sense.
    CC: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    CC: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
    Signed-off-by: default avatarBorislav Petkov <petkovbb@gmail.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
ide-cd.c 46.3 KB