Skip to content
  • Johannes Berg's avatar
    mac80211: fix work removal on deauth request · bc4934bc
    Johannes Berg authored
    
    
    When deauth is requested while an auth or assoc
    work item is in progress, we currently delete it
    without regard for any state it might need to
    clean up. Fix it by cleaning up for those items.
    
    In the case Pontus found, the problem manifested
    itself as such:
    
    authenticate with 00:23:69:aa:dd:7b (try 1)
    authenticated
    failed to insert Dummy STA entry for the AP (error -17)
    deauthenticating from 00:23:69:aa:dd:7b by local choice (reason=2)
    
    It could also happen differently if the driver
    uses the tx_sync callback.
    
    We can't just call the ->done() method of the work
    items because that will lock up due to the locking
    in cfg80211. This fix isn't very clean, but that
    seems acceptable since I have patches pending to
    remove this code completely.
    
    Cc: stable@vger.kernel.org
    Reported-by: default avatarPontus Fuchs <pontus.fuchs@gmail.com>
    Tested-by: default avatarPontus Fuchs <pontus.fuchs@gmail.com>
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    bc4934bc