Skip to content
  • Tejun Heo's avatar
    block: fix failfast merge testing in elv_rq_merge_ok() · 0a09f431
    Tejun Heo authored
    Commit ab0fd1de
    
     tries to prevent merge
    of requests with different failfast settings.  In elv_rq_merge_ok(),
    it compares new bio's failfast flags against the merge target
    request's.  However, the flag testing accessors for bio and blk don't
    return boolean but the tested bit value directly and FAILFAST on bio
    and blk don't match, so directly comparing them with == results in
    false negative unnecessary preventing merge of readahead requests.
    
    This patch convert the results to boolean by negating them before
    comparison.
    
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Cc: Jens Axboe <jens.axboe@oracle.com>
    Cc: Boaz Harrosh <bharrosh@panasas.com>
    Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
    Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
    Cc: Jeff Garzik <jeff@garzik.org>
    0a09f431