• Herbert Xu's avatar
    crypto: api - Fix algorithm test race that broke aead initialisation · b8e15992
    Herbert Xu authored
    When we complete a test we'll notify everyone waiting on it, drop
    the mutex, and then remove the test larval (after reacquiring the
    mutex).  If one of the notified parties tries to register another
    algorithm with the same driver name prior to the removal of the
    test larval, they will fail with EEXIST as only one algorithm of
    a given name can be tested at any time.
    This broke the initialisation of aead and givcipher algorithms as
    they will register two algorithms with the same driver name, in
    This patch fixes the problem by marking the larval as dead before
    we drop the mutex, and also ignoring all dead or dying algorithms
    on the registration path.
    Tested-by: default avatarAndreas Steffen <andreas.steffen@strongswan.org>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
algapi.c 16.3 KB