Skip to content
  • Daniel Walker's avatar
    usb: u132-hcd driver style clean up · b40f8d39
    Daniel Walker authored
    
    
    I was converting a semaphore in this file to a mutex when I noticed that
    this file has some fairly rampant style problems. Practically every line
    has spaces instead of tabs .. Once I cleared that up, checkpatch.pl showed
    a number of other problem.. I think this file might be a good one to review
    for new style checks that could be added..
    
    Below are the only two remaining which I didn't remove. 
    
    #5083: FILE: drivers/usb/host/u132-hcd.c:2907:
    +               error:
    
    WARNING: labels should not be indented
    #5087: FILE: drivers/usb/host/u132-hcd.c:2911:
    +               stall:
    
    These labels are actually inside a switch statement, and they are right
    under "default:". "default:" appears to be exempt and these other label
    should be too, or default shouldn't be exempt.
    
    I also deleted a few lines due to single statements inside { } , 
    
    if (is_error()) {
    	return;
    }
    
    becomes,
    
    if (is_error())
    	return;
    
    with one line deleted.
    
    Signed-off-by: default avatarDaniel Walker <dwalker@mvista.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    b40f8d39