Skip to content
  • Eugene Teo's avatar
    wan: Missing capability checks in sbni_ioctl() · f2455eb1
    Eugene Teo authored
    
    
    There are missing capability checks in the following code:
    
    1300 static int
    1301 sbni_ioctl( struct net_device  *dev,  struct ifreq  *ifr,  int  cmd)
    1302 {
    [...]
    1319     case  SIOCDEVRESINSTATS :
    1320         if( current->euid != 0 )    /* root only */
    1321             return  -EPERM;
    [...]
    1336     case  SIOCDEVSHWSTATE :
    1337         if( current->euid != 0 )    /* root only */
    1338             return  -EPERM;
    [...]
    1357     case  SIOCDEVENSLAVE :
    1358         if( current->euid != 0 )    /* root only */
    1359             return  -EPERM;
    [...]
    1372     case  SIOCDEVEMANSIPATE :
    1373         if( current->euid != 0 )    /* root only */
    1374             return  -EPERM;
    
    Here's my proposed fix:
    
    Missing capability checks.
    
    Signed-off-by: default avatarEugene Teo <eugeneteo@kernel.sg>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f2455eb1