• Jon Hunter's avatar
    irqchip: Mask the non-type/sense bits when translating an IRQ · a2a8fa55
    Jon Hunter authored
    The firmware parameter that contains the IRQ sense bits may also contain
    other data. When return the IRQ type, bits outside of these sense bits
    should be masked. If these bits are not masked and
    irq_create_fwspec_mapping() is called to map an IRQ, then the comparison
    of the type returned from irq_domain_translate() will never match
    that returned by irq_get_trigger_type() (because this function masks the
    none sense bits) and so we will always call irq_set_irq_type() to program
    the type even if it was not really necessary.
    Currently, the downside to this is unnecessarily re-programmming the type
    but nevertheless this should be avoided.
    The Tegra LIC and TI Crossbar irqchips all have client instances (from
    reviewing the device-tree sources) where bits outside the IRQ sense bits
    are set, but do not mask these bits. Therefore, ensure these bits are
    masked for these irqchips.
    Signed-off-by: default avatarJon Hunter <jonathanh@nvidia.com>
    Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
    Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
irq-tegra.c 8.86 KB