Skip to content
  • Bob Peterson's avatar
    [GFS2] kernel panic mounting volume · 9171f5a9
    Bob Peterson authored
    
    
    This patch fixes Red Hat bugzilla bug 450156.
    
    This started with a not-too-improbable mount failure because the
    locking protocol was never set back to its proper "lock_dlm" after the
    system was rebooted in the middle of a gfs2_fsck.  That left a
    (purposely) invalid locking protocol in the superblock, which caused an
    error when the file system was mounted the next time.
    
    When there's an error mounting, vfs calls DQUOT_OFF, which calls
    vfs_quota_off which calls gfs2_sync_fs.  Next, gfs2_sync_fs calls
    gfs2_log_flush passing s_fs_info.  But due to the error, s_fs_info
    had been previously set to NULL, and so we have the kernel oops.
    
    My solution in this patch is to test for the NULL value before passing
    it.  I tested this patch and it fixes the problem.
    
    Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
    9171f5a9