Skip to content
  • David Brownell's avatar
    USB: serial gadget: cleanup/reorg · 9079e91b
    David Brownell authored
    
    
    Some cleanup/reorg of g_serial ... simplifying it, and disentangling
    its structure so morphing it into a "function" driver (combinable with
    other interfaces) should be less painful.
    
     - Remove most forward declarations
         * put tty and gadget driver structs after their contents
         * snug module init/exit decls next to their functions
         * reordered some functions
    
     - Other cleanup:
         * convert a funky macro to an inline function
         * snug up module params next to their declarations
         * add missing driver.owner
         * add separator lines between major driver sections
    
     - Add comments re potential parameter/#define changes:
         * only supports one port (shrank GS_NUM_PORTS)
         * changing from 9600-8-N-1 affects multiple sites
    
     - Remove net2280-specific optimization ... it was being done
       way too late, can be done by net2280 module options, and in
       any case doesn't matter at any sane serial data rates.
    
    There are no behavioral changes, but the macro thing saves I-space.
    
    Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
    Cc: Al Borchers <alborchers@steinerpoint.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    
    9079e91b