• Thadeu Lima de Souza Cascardo's avatar
    qlge: fix size of external list for TX address descriptors · 78242853
    Thadeu Lima de Souza Cascardo authored
    When transmiting a fragmented skb, qlge fills a descriptor with the
    fragment addresses, after DMA-mapping them. If there are more than eight
    fragments, it will use the eighth descriptor as a pointer to an external
    list. After mapping this external list, called OAL to a structure
    containing more descriptors, it fills it with the extra fragments.
    However, considering that systems with pages larger than 8KiB would have
    less than 8 fragments, which was true before commit a715dea3
    , it
    defined a macro for the OAL size as 0 in those cases.
    Now, if a skb with more than 8 fragments (counting skb->data as one
    fragment), this would start overwriting the list of addresses already
    mapped and would make the driver fail to properly unmap the right
    addresses on architectures with pages larger than 8KiB.
    Besides that, the list of mappings was one size too small, since it must
    have a mapping for the maxinum number of skb fragments plus one for
    skb->data and another for the OAL. So, even on architectures with page
    sizes 4KiB and 8KiB, a skb with the maximum number of fragments would
    make the driver overwrite its counter for the number of mappings, which,
    again, would make it fail to unmap the mapped DMA addresses.
    Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
qlge.h 62.3 KB