Skip to content
  • Ryusuke Konishi's avatar
    nilfs2: fix regression that i-flag is not set on changeless checkpoints · 72746ac6
    Ryusuke Konishi authored
    
    
    According to the report from Jiro SEKIBA titled "regression in
    2.6.37?"  (Message-Id: <8739n8vs1f.wl%jir@sekiba.com>), on 2.6.37 and
    later kernels, lscp command no longer displays "i" flag on checkpoints
    that snapshot operations or garbage collection created.
    
    This is a regression of nilfs2 checkpointing function, and it's
    critical since it broke behavior of a part of nilfs2 applications.
    For instance, snapshot manager of TimeBrowse gets to create
    meaningless snapshots continuously; snapshot creation triggers another
    checkpoint, but applications cannot distinguish whether the new
    checkpoint contains meaningful changes or not without the i-flag.
    
    This patch fixes the regression and brings that application behavior
    back to normal.
    
    Reported-by: default avatarJiro SEKIBA <jir@unicus.jp>
    Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Tested-by: default avatarRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Tested-by: default avatarJiro SEKIBA <jir@unicus.jp>
    Cc: stable <stable@kernel.org>  [2.6.37]
    72746ac6