Skip to content
  • Felix Fietkau's avatar
    ath5k: fix tx status reporting issues · 6d7b97b2
    Felix Fietkau authored
    
    
    During normal operation, minstrel was showing suspicious EWMA probabilities
    exceeding 100%. It looks like the tx status reporting in ath5k was not
    properly clearing the rate index for rates which were never attempted.
    
    This is caused by uninitialized stale data in the on-stack tx status
    information, which is reused when more frames are received.
    
    To fix this, rely on ts->ts_final_idx to select the last attempted rate,
    instead of checking whether ts->ts_rate is set.
    
    Additionally, the conversion from the driver rate index back to the
    mac80211 rate index can be dropped, as the mac80211 tx status will still
    have the original rate index which was used to set up the descriptor.
    
    Additionally, one more inaccuracy was fixed - the final rate attempt
    count only needs to be increased by one if the transmission attempt was
    successful.
    
    Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    6d7b97b2