Skip to content
  • FUJITA Tomonori's avatar
    scsi: convert discard to REQ_TYPE_FS from REQ_TYPE_BLOCK_PC · 6a32a8ae
    FUJITA Tomonori authored
    
    
    Jens, any reason why this isn't included in your for-2.6.36 yet?
    
    =
    From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
    Subject: [PATCH resend] scsi: convert discard to REQ_TYPE_FS from REQ_TYPE_BLOCK_PC
    
    The block layer (file systems) sends discard requests as REQ_TYPE_FS
    (the role of REQ_TYPE_FS is that setting up commands and interpreting
    the results). But SCSI-ml treats discard requests as
    REQ_TYPE_BLOCK_PC.
    
    scsi-ml can handle discard requests as REQ_TYPE_FS
    easily. scsi_setup_discard_cmnd() sets up struct request and the bio
    nicely. Only remaining issue is that discard requests can't be
    completed partially so we need to modify sd_done.
    
    This conversion also fixes the problem that discard requests aren't
    retried when possible (e.g. UNIT ATTENTION).
    
    Signed-off-by: default avatarFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
    6a32a8ae