Skip to content
  • Alex Elder's avatar
    xfs: fix min bufsize bugs in two places · 6881a229
    Alex Elder authored
    
    
    This fixes a bug in two places that I found by inspection.  In
    xlog_find_verify_cycle() and xlog_write_log_records(), the code
    attempts to allocate a buffer to hold as many blocks as possible.
    It gives up if the number of blocks to be allocated gets too small.
    Right now it uses log->l_sectbb_log as that lower bound, but I'm
    sure it's supposed to be the actual log sector size instead.  That
    is, the lower bound should be (1 << log->l_sectbb_log).
    
    Also define a simple macro xlog_sectbb(log) to represent the number
    of basic blocks in a sector for the given log.
    
    (No change from original submission; I have implemented Christoph's
    suggestion about storing l_sectsize rather than l_sectbb_log in
    a new, separate patch in this series.)
    
    Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
    6881a229