Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • X xcap-capability-linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • xcap
  • xcap-capability-linux
  • Repository
Switch branch/tag
  • xcap-capability-linux
  • fs
  • cifs
  • cifssmb.c
Find file BlameHistoryPermalink
  • Jeff Layton's avatar
    cifs: don't try to unlock pagecache page after releasing it · 94e18007
    Jeff Layton authored Mar 04, 2013
    
    
    We had a recent fix to fix the release of pagecache pages when
    cifs_writev_requeue writes fail. Unfortunately, it releases the page
    before trying to unlock it. At that point, the page might be gone by the
    time the unlock comes in.
    
    Unlock the page first before checking the value of "rc", and only then
    end writeback and release the pages. The page lock isn't required for
    any of those operations so this should be safe.
    
    Reported-by: default avatarAnton Altaparmakov <aia21@cam.ac.uk>
    Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
    Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
    94e18007