Skip to content
  • Alexey Dobriyan's avatar
    [PATCH 1/2] proc: fix inode number bogorithmetic · 67935df4
    Alexey Dobriyan authored
    
    
    Id which proc gets from IDR for inode number and id which proc removes
    from IDR do not match. E.g. 0x11a transforms into 0x8000011a.
    
    Which stayed unnoticed for a long time because, surprise, idr_remove()
    masks out that high bit before doing anything.
    
    All of this due to "| ~MAX_ID_MASK" in release_inode_number().
    
    I still don't understand how it's supposed to work, because "| ~MASK"
    is not an inversion for "& MAX" operation.
    
    So, use just one nice, working addition. Make start offset unsigned int,
    while I'm at it. It's longness is not used anywhere.
    
    Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    67935df4