• Tejun Heo's avatar
    block: set rq->resid_len to blk_rq_bytes() on issue · 5f49f631
    Tejun Heo authored
    In commit c3a4d78c, while introducing
    rq->resid_len, the default value of residue count was changed from
    full count to zero.  The conversion was done under the assumption that
    when a request fails residue count wasn't defined.  However, Boaz and
    James pointed out that this wasn't true and the residue count should
    be preserved for failed requests too.
    This patchset restores the original behavior by setting rq->resid_len
    to blk_rq_bytes(rq) on request start and restoring explicit clearing
    in affected drivers.  While at it, take advantage of the fact that
    rq->resid_len is set to full count where applicable.
    * ide-cd: rq->resid_len cleared on pc success
    * mptsas: req->resid_len cleared on success
    * sas_expander: rsp/req->resid_len cleared on success
    * mpt2sas_transport: req->resid_len cleared on success
    * ide-cd, ide-tape, mptsas, sas_host_smp, mpt2sas_transport, ub: take
      advantage of initial full count to simplify code
    Boaz Harrosh spotted bug in resid_len initialization.  Fixed as
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Acked-by: default avatarBorislav Petkov <petkovbb@googlemail.com>
    Cc: Boaz Harrosh <bharrosh@panasas.com>
    Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
    Cc: Pete Zaitcev <zaitcev@redhat.com>
    Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
    Cc: Eric Moore <Eric.Moore@lsi.com>
    Cc: Darrick J. Wong <djwong@us.ibm.com>
    Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
ide-cd.c 46 KB