• Kiyoshi Ueda's avatar
    blk_end_request: changing ide normal caller (take 4) · 5e36bb6e
    Kiyoshi Ueda authored
    
    
    This patch converts "normal" parts of ide to use blk_end_request
    interfaces.  Related 'uptodate' arguments are converted to 'error'.
    
    The conversion of 'uptodate' to 'error' is done only for the internal
    function, __ide_end_request().
    ide_end_request() was not changed since it's exported and used
    by many ide drivers.
    
    With this patch, blkdev_dequeue_request() in __ide_end_request() is
    moved to blk_end_request, since blk_end_request takes care of
    dequeueing request like below:
    
    	if (!list_empty(&rq->queuelist))
    		blkdev_dequeue_request(rq);
    
    In the case of ide,
      o 'dequeue' variable of __ide_end_request() is 1 only when the request
        is still linked to the queue (i.e. rq->queuelist is not empty)
      o 'dequeue' variable of __ide_end_request() is 0 only when the request
        has already been removed from the queue (i.e. rq->queuelist is empty)
    So blk_end_request can handle it correctly although ide always run
    thought the code above.
    
    Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Signed-off-by: default avatarKiyoshi Ueda <k-ueda@ct.jp.nec.com>
    Signed-off-by: default avatarJun'ichi Nomura <j-nomura@ce.jp.nec.com>
    Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
    5e36bb6e