Skip to content
  • Eric Dumazet's avatar
    net: make sure struct dst_entry refcount is aligned on 64 bytes · 5635c10d
    Eric Dumazet authored
    As found in the past (commit f1dd9c37
    
    
    [NET]: Fix tbench regression in 2.6.25-rc1), it is really
    important that struct dst_entry refcount is aligned on a cache line.
    
    We cannot use __atribute((aligned)), so manually pad the structure
    for 32 and 64 bit arches.
    
    for 32bit : offsetof(truct dst_entry, __refcnt) is 0x80
    for 64bit : offsetof(truct dst_entry, __refcnt) is 0xc0
    
    As it is not possible to guess at compile time cache line size,
    we use a generic value of 64 bytes, that satisfies many current arches.
    (Using 128 bytes alignment on 64bit arches would waste 64 bytes)
    
    Add a BUILD_BUG_ON to catch future updates to "struct dst_entry" dont
    break this alignment.
    
    "tbench 8" is 4.4 % faster on a dual quad core (HP BL460c G1), Intel E5450 @3.00GHz
    (2350 MB/s instead of 2250 MB/s)
    
    Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    5635c10d