Skip to content
  • Bart Van Assche's avatar
    locking/spinlocks: Always evaluate the second argument of spin_lock_nested() · 4999201a
    Bart Van Assche authored
    
    
    Evaluating a macro argument only if certain configuration options
    have been selected is confusing and error-prone. Hence always
    evaluate the second argument of spin_lock_nested().
    
    An intentional side effect of this patch is that it avoids that
    the following warning is reported for netif_addr_lock_nested()
    when building with CONFIG_DEBUG_LOCK_ALLOC=n and with W=1:
    
      include/linux/netdevice.h: In function 'netif_addr_lock_nested':
      include/linux/netdevice.h:2865:6: warning: variable 'subclass' set but not used [-Wunused-but-set-variable]
        int subclass = SINGLE_DEPTH_NESTING;
            ^
    
    Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
    Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
    Cc: David Rientjes <rientjes@google.com>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Link: http://lkml.kernel.org/r/53E4A7F8.1040700@acm.org
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    4999201a