Skip to content
  • Ian Abbott's avatar
    staging: comedi: amplc_dio200: fix possible NULL deref during detach · dfb2540e
    Ian Abbott authored
    
    
    `dio200_detach()` is called by the comedi core to clean up if either
    `dio200_attach()` or `dio200_attach_pci()` return an error.  It assigns
    `thisboard` to the return value of `comedi_board(dev)` and assumes it is
    non-null.  In the case of a previous call to `dio200_attach()` it won't
    be `NULL` because the comedi core will have pointed it to one of the
    elements of `dio200_boards[]`, but in the case of a previous call to
    `dio200_attach_pci()` it could be `NULL`, leading to a null pointer
    dereference.
    
    Check that `thisboard` is valid at the top of `dio200_detach()` and
    return early if it is `NULL`.  This is okay because the only other thing
    that could have been allocated is `dev->private` and that is freed by
    the comedi core, not by this function.
    
    Cc: <stable@vger.kernel.org> # 3.6.x
    Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    dfb2540e