Skip to content
  • Johannes Berg's avatar
    mac80211: fix sw crypto · 382b1655
    Johannes Berg authored
    What a stupid mistake. In
    
        commit 813d7669
    
    
        Author: Johannes Berg <johannes@sipsolutions.net>
        Date:   Sun Jan 17 01:47:58 2010 +0100
    
            mac80211: move control.hw_key assignment
    
    I inserted code testing the wrong flags field,
    which means that the test is almost always true
    (it's really testing for the peer's WMM support)
    and thus the later parts of the stack assume hw
    crypto will be done even if that's not true.
    
    Obviously, that broke software crypto. Maxim
    said so specifically, and Jochen probably uses
    some cipher that iwl3945 doesn't support in
    hardware, which might also explain that Maxim
    reports that even hw crypto is broken.
    
    Fix this to test the right flags field.
    
    Reported-by: default avatarMaxim Levitsky <maximlevitsky@gmail.com>
    Reported-by: default avatarJochen Friedrich <jochen@scram.de>
    Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    382b1655