Skip to content
  • Stanislaw Gruszka's avatar
    iwlwifi: fix enqueue hcmd race conditions · 3598e177
    Stanislaw Gruszka authored
    We mark command as huge by using meta->flags from other (non huge) command,
    but flags can be possibly overridden, when non huge command is enqueued,
    what can lead to:
    WARNING: at lib/dma-debug.c:696 dma_debug_device_change+0x1a3/0x1f0()
    DMA-API: device driver has pending DMA allocations while released from device [count=1]
    To fix introduce additional CMD_MAPPED to mark command as mapped and
    serialize iwl_enqueue_hcmd() with iwl_tx_cmd_complete() using
    hcmd_lock. Serialization will also fix possible race conditions,
    because q->read_ptr, q->write_ptr are modified/used in parallel.
    On the way fix whitespace.
    Signed-off-by: default avatarStanislaw Gruszka <>
    Acked-by: default avatarWey-Yi Guy <>
    Signed-off-by: default avatarJohn W. Linville <>