• Wengang Wang's avatar
    GFS2: free disk inode which is deleted by remote node -V2 · 970343cd
    Wengang Wang authored
    this patch is for the same problem that Benjamin Marzinski fixes at commit
    quotation of the original problem:
    ---cut here---
    When a file is deleted from a gfs2 filesystem on one node, a dcache
    entry for it may still exist on other nodes in the cluster. If this
    happens, gfs2 will be unable to free this file on disk. Because of this,
    it's possible to have a gfs2 filesystem with no files on it and no free
    space. With this patch, when a node receives a callback notifying it
    that the file is being deleted on another node, it schedules a new
    workqueue thread to remove the file's dcache entry.
    ---end cut---
    after applying Benjamin's patch, I think there is still a case in which the disk
    inode remains even when "no space" is hit. the case is that when running
    d_prune_aliases() against the inode, there are one or more dentries(aliases)
    which have reference count number > 0. in this case the dentries won't be pruned.
    and even later, the reference count becomes to 0, the dentries can still be
    cached in memory. unfortunately, no callback come again, things come back to
    the state before the callback runs. thus the on disk inode remains there until
    in memoryinode is removed for some other reason(shrinking inode cache or unmount
    the volume..).
    this patch is to remove those dentries when their reference count becomes to 0 and
    the inode is deleted by remote node. for implementation, gfs2_dentry_delete() is
    added as dentry_operations.d_delete. the function returns true when the inode is
    deleted by remote node. in dput(), gfs2_dentry_delete() is called and since it
    returns true, the dentry is unhashed from dcache and then removed. when all dentries
    are removed, the in memory inode get removed so that the on disk inode is freed.
    Signed-off-by: default avatarWengang Wang <wen.gang.wang@oracle.com>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
dentry.c 2.72 KB