Skip to content
  • Arnaldo Carvalho de Melo's avatar
    [TCP]: Change tcp_header_len member in tcp_sock to u16 · 2ff52f28
    Arnaldo Carvalho de Melo authored
    
    
    With this we eliminate the last hole in struct tcp_sock.
    
    End result:
    
    [acme@newtoy net-2.6.20]$ codiff -sV /tmp/tcp.o.before net/ipv4/tcp.o
    /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp.c:
      struct tcp_sock |   -4
        tcp_header_len;
         from: int                   /*  1000(0)     4(0) */
         to:   u16                   /*  1000(0)     2(0) */
     1 struct changed
    [acme@newtoy net-2.6.20]$
    
    Now sizeof(tcp_sock) is just...
    
    [acme@newtoy net-2.6.20]$ pahole --sizes ../OUTPUT/qemu/net-2.6.20/net/ipv4/tcp.o | grep -w tcp_sock
    struct tcp_sock: 1500 0
    
    1500 bytes ;-)
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@mandriva.com>
    2ff52f28