Skip to content
  • Patrick Mochel's avatar
    [PATCH] usb: klist_node_attached() fix · 273971ba
    Patrick Mochel authored
    
    
    The original code looks like this:
    
            /* if interface was already added, bind now; else let
             * the future device_add() bind it, bypassing probe()
             */
            if (!list_empty (&dev->bus_list))
                    device_bind_driver(dev);
    
    IOW, it's checking to see if the device is attached to the bus or not
    and binding the driver if it is. It's checking the device's bus list,
    which will only appear empty when the device has been initialized, but
    not added. It depends way too much on the driver model internals, but it
    seems to be the only way to do the weird crap they want to do with
    interfaces.
    
    When I converted it to use klists, I accidentally inverted the logic,
    which led to bad things happening. This patch returns the check to its
    orginal value.
    
    From: Patrick Mochel <mochel@digitalimplant.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    
    Index: gregkh-2.6/drivers/usb/core/usb.c
    ===================================================================
    273971ba