Skip to content
Snippets Groups Projects
  • Stefan Richter's avatar
    3ac26b2e
    firewire: cdev: mark char device files as not seekable · 3ac26b2e
    Stefan Richter authored
    
    The <linux/firewire-cdev.h> character device file ABI (i.e. /dev/fw*
    character device file interface) does not make any use of lseek(),
    pread(), pwrite() (or any kind of write() at all).
    
    Use nonseekable_open() and, redundantly, set file_operations.llseek to
    no_llseek to remove any doubt whether the BKL-grabbing default_llseek
    handler is used.  (Also shuffle file_operations initialization according
    to the order of handler definitions.)
    
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    3ac26b2e
    History
    firewire: cdev: mark char device files as not seekable
    Stefan Richter authored
    
    The <linux/firewire-cdev.h> character device file ABI (i.e. /dev/fw*
    character device file interface) does not make any use of lseek(),
    pread(), pwrite() (or any kind of write() at all).
    
    Use nonseekable_open() and, redundantly, set file_operations.llseek to
    no_llseek to remove any doubt whether the BKL-grabbing default_llseek
    handler is used.  (Also shuffle file_operations initialization according
    to the order of handler definitions.)
    
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>