• Florian Fainelli's avatar
    net: dsa: bcm_sf2: Fix race condition while unmasking interrupts · 4f101c47
    Florian Fainelli authored
    We kept shadow copies of which interrupt sources we have enabled and
    disabled, but due to an order bug in how intrl2_mask_clear was defined,
    we could run into the following scenario:
    CPU0					CPU1
    					read INTRL2_CPU_STATUS and masks with stale
    					irq1_mask value
    updates irq1_mask value
    Which would make us loop again and again trying to process and interrupt
    we are not clearing since our copy of whether it was enabled before
    still indicates it was not. Fix this by updating the shadow copy first,
    and then unasking at the HW level.
    Fixes: 246d7f77 ("net: dsa: add Broadcom SF2 switch driver")
    Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
bcm_sf2.h 5.39 KB