Skip to content
  • Yinghai Lu's avatar
    x86: agp_gart size checking for buggy device · 1edc1ab3
    Yinghai Lu authored
    
    
    while looking at Rafael J. Wysocki's system boot log,
    
    I found a funny printout:
    
    	Node 0: aperture @ de000000 size 32 MB
    	Aperture too small (32 MB)
    	AGP bridge at 00:04:00
    	Aperture from AGP @ de000000 size 4096 MB (APSIZE 0)
    	Aperture too small (0 MB)
    	Your BIOS doesn't leave a aperture memory hole
    	Please enable the IOMMU option in the BIOS setup
    	This costs you 64 MB of RAM
    	Mapping aperture over 65536 KB of RAM @ 4000000
    
    	...
    
    	agpgart: Detected AGP bridge 20
    	agpgart: Aperture pointing to RAM
    	agpgart: Aperture from AGP @ de000000 size 4096 MB
    	agpgart: Aperture too small (0 MB)
    	agpgart: No usable aperture found.
    	agpgart: Consider rebooting with iommu=memaper=2 to get a good aperture.
    
    it means BIOS allocated the correct gart on the NB and AGP bridge, but
    because a bug in the silicon (the agp bridge reports the wrong order,
    it wants 4G instead) the kernel will reject that allocation.
    
    Also, because the size is only 32MB, and we try to get another 64M for gart,
    late fix_northbridge can not revert that change because it still reads
    the wrong size from agp bridge.
    
    So try to double check the order value from the agp bridge, before calling
    aperture_valid().
    
    [ mingo@elte.hu: 32-bit fix. ]
    
    Signed-off-by: default avatarYinghai Lu <yhlu.kernel@gmail.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    1edc1ab3