• Josef Whiter's avatar
    [GFS2] Fix bz 231380, unlock page before dequeing glocks in gfs2_commit_write · 1de91390
    Josef Whiter authored
    If we are writing a file, and in the middle of writing the file
    another node attempts to get a shared lock on that file (by doing a du for
    example) the process doing the writing will hang waiting on lock_page.  The
    reason for this is because when we have waiters on a exclusive glock, we will go
    through and flush out all dirty pages associated with that inode and release the
    lock.  The problem is that when we flush the dirty pages, we could hit a page
    that we have locked durring the generic_file_buffered_write part of this
    operation.  This patch unlocks the page before we go to dequeue the lock and
    locks it immediatly afterwards, since generic_file_buffered_write needs the page
    locked when the commit_write is completed.  This patch resolves the problem,
    however if somebody sees a better way to do this please don't hesistate to yell.
    Signed-off-by: default avatarJosef Whiter <jwhiter@redhat.com>
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
ops_address.c 19.8 KB