Skip to content
  • J. Bruce Fields's avatar
    nfsd4: don't remap EISDIR errors in rename · 2a6cf944
    J. Bruce Fields authored
    
    
    We're going out of our way here to remap an error to make rfc 3530
    happy--but the rfc itself (nor rfc 1813, which has similar language)
    gives no justification.  And disagrees with local filesystem behavior,
    with Linux and posix man pages, and knfsd's implemented behavior for v2
    and v3.
    
    And the documented behavior seems better, in that it gives a little more
    information--you could implement the 3530 behavior using the posix
    behavior, but not the other way around.
    
    Also, the Linux client makes no attempt to remap this error in the v4
    case, so it can end up just returning EEXIST to the application in a
    case where it should return EISDIR.
    
    So honestly I think the rfc's are just buggy here--or in any case it
    doesn't see worth the trouble to remap this error.
    
    Reported-by: default avatarFrank S Filz <ffilz@us.ibm.com>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    2a6cf944