Skip to content
  • Daniel Drake's avatar
    [CPUFREQ] powernow-k7: fix MHz rounding issue with perflib · dc2585eb
    Daniel Drake authored
    When the PST tables are broken, powernow-k7 uses ACPI's processor_perflib to
    deduce the available frequency multipliers from the _PSS tables.
    
    Upon frequency change, processor_perflib performs some verification on the
    frequency (checks that it's within allowable bounds).
    
    powernow-k7 deals with absolute frequencies in KHz, whereas perflib only
    deals with MHz values. When performing the above verification, perflib
    multiplies the MHz values by 1000 to obtain the KHz value.
    
    We then end up with situations like the following:
     - powernow-k7 multiplies the multiplier by the FSB, and obtains a value
       such as 1266768 KHz
     - perflib belives the same state has frequency of 1266 MHz
     - acpi_processor_ppc_notifier calls cpufreq_verify_within_limits to verify
       that 1266768 is in the allowable range of 0 to 1266000 (i.e. 1266 * 1000)
     - it's not, so that frequency is rejected
     - the maximum CPU frequency is not reachable
    
    This patch solves the problem by rounding up the MHz values stored in perflib's
    tables. Additionally it corrects a broken URL.
    
    It also fixes http://bugzilla.kernel.org/show_bug.cgi?id=8255
    
     although this
    case is a bit different: the frequencies in the _PSS tables are wildly wrong,
    but we get better results if we force ACPI to respect the fsb * multiplier
    calculations (even though it seems that the multiplier values aren't entirely
    correct either).
    
    Signed-off-by: default avatarDaniel Drake <dsd@gentoo.org>
    Signed-off-by: default avatarDave Jones <davej@redhat.com>
    dc2585eb