Skip to content
  • Stefan Richter's avatar
    firewire: normalize status values in packet callbacks · 18d0cdfd
    Stefan Richter authored
    
    
    core-transaction.c transmit_complete_callback() and close_transaction()
    expect packet callback status to be an ACK or RCODE, and ACKs get
    translated to RCODEs for transaction callbacks.
    
    An old comment on the packet callback API (been there from the initial
    submission of the stack) and the dummy_driver implementation of
    send_request/send_response deviated from this as they also included
    -ERRNO in the range of status values.
    
    Let's narrow status values down to ACK and RCODE to prevent surprises.
    RCODE_CANCELLED is chosen as the dummy_driver's RCODE as its meaning of
    "transaction timed out" comes closest to what happens when a transaction
    coincides with card removal.
    
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    18d0cdfd