Skip to content
  • Stephen Boyd's avatar
    tick: broadcast: Check broadcast mode on CPU hotplug · a272dcca
    Stephen Boyd authored
    
    
    On ARM systems the dummy clockevent is registered with the cpu
    hotplug notifier chain before any other per-cpu clockevent. This
    has the side-effect of causing the dummy clockevent to be
    registered first in every hotplug sequence. Because the dummy is
    first, we'll try to turn the broadcast source on but the code in
    tick_device_uses_broadcast() assumes the broadcast source is in
    periodic mode and calls tick_broadcast_start_periodic()
    unconditionally.
    
    On boot this isn't a problem because we typically haven't
    switched into oneshot mode yet (if at all). During hotplug, if
    the broadcast source isn't in periodic mode we'll replace the
    broadcast oneshot handler with the broadcast periodic handler and
    start emulating oneshot mode when we shouldn't. Due to the way
    the broadcast oneshot handler programs the next_event it's
    possible for it to contain KTIME_MAX and cause us to hang the
    system when the periodic handler tries to program the next tick.
    Fix this by using the appropriate function to start the broadcast
    source.
    
    Reported-by: default avatarStephen Warren <swarren@nvidia.com>
    Tested-by: default avatarStephen Warren <swarren@nvidia.com>
    Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
    Cc: Mark Rutland <Mark.Rutland@arm.com>
    Cc: Marc Zyngier <marc.zyngier@arm.com>
    Cc: ARM kernel mailing list <linux-arm-kernel@lists.infradead.org>
    Cc: John Stultz <john.stultz@linaro.org>
    Cc: Joseph Lo <josephl@nvidia.com>
    Link: http://lkml.kernel.org/r/20130711140059.GA27430@codeaurora.org
    
    
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    a272dcca