Skip to content
  • KOSAKI Motohiro's avatar
    mm: __rmqueue_fallback() should respect pageblock type · 0cbef29a
    KOSAKI Motohiro authored
    When __rmqueue_fallback() doesn't find a free block with the required size
    it splits a larger page and puts the rest of the page onto the free list.
    
    But it has one serious mistake.  When putting back, __rmqueue_fallback()
    always use start_migratetype if type is not CMA.  However,
    __rmqueue_fallback() is only called when all of the start_migratetype
    queue is empty.  That said, __rmqueue_fallback always puts back memory to
    the wrong queue except try_to_steal_freepages() changed pageblock type
    (i.e.  requested size is smaller than half of page block).  The end result
    is that the antifragmentation framework increases fragmenation instead of
    decreasing it.
    
    Mel's original anti fragmentation does the right thing.  But commit
    47118af0 ("mm: mmzone: MIGRATE_CMA migration type added") broke it.
    
    This patch restores sane and old behavior.  It also removes an incorrect
    comment which was introduced by commit fef903ef
    
     ("mm/page_alloc.c:
    restructure free-page stealing code and fix a bug").
    
    Signed-off-by: default avatarKOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    Cc: Mel Gorman <mgorman@suse.de>
    Cc: Michal Nazarewicz <mina86@mina86.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    0cbef29a