Skip to content
  • David Brownell's avatar
    spi device setup gets better error checking · 082c8cb4
    David Brownell authored
    
    
    This updates some error reporting paths in SPI device setup:
    
     - Move validation logic for SPI chipselects to spi_new_device(),
       which is where it should always have been.
    
     - In spi_new_device(), emit error messages if the device can't
       be created.  This is LOTS better than a silent failure; though
       eventually, the calling convention should probably change to
       use the <linux/err.h> conventions.
    
     - Includes one previously-missing check:  SPI masters must always
       have at least one chipselect, even for dedicated busses which
       always keep it selected!
    
    It also adds a FIXME (IDR for dynamic ID allocation) so the issue doesn't live
    purely in my mailbox.
    
    Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    082c8cb4