Skip to content
  • Fubo Chen's avatar
    [SCSI] target: Remove unnecessary hba_dev_list walk and se_clear_dev_ports legacy code · 05aea6e7
    Fubo Chen authored
    
    
    This patch removes a legacy struct se_hba->hba_dev_list -> se_release_device_for_hba()
    list walk in core_delete_hba(), which is no longer required while using configfs
    VFS level parent/child struct config_group dependency referencing.  The reason
    is because any struct se_hba->hba_dev_list-> struct se_device members are going
    to have to be released via:
    
    	rmdir /sys/kernel/config/target/core/$HBA/*
    
    before rmdir release of struct se_hba via target_core_configfs.c:
    target_core_call_delhbafromtarget() -> core_delete_hba()
    
    	rmdir /sys/kernel/config/target/core/$HBA
    
    to release struct se_hba in core_delete_hba().
    
    This patch also removes the legacy se_clear_dev_ports() function, which is
    left-over pre-configfs shutdown logic for when se_free_virtual_device()
    was responsible for walking struct se_device->dev_sep_list and calling
    core_dev_del_lun() for each individual active struct se_port->se_lun.
    
    The reason this can be removed is because all struct se_device->dev_sep_list
    -> struct se_port communication is done via configfs symlinks, which
    means that an target fabric module's endpoints containg active struct
    se_port(s) will have to be released via target_core_fabric_configfs.c:
    target_fabric_port_unlink() via:
    
    	unlink /sys/kernel/config/target/$FABRIC_MOD/$ENDPOINT/tpgt_$TPGT/lun/lun_$LUN_ID/<symlink>
    
    before rmdir release of struct se_device in target_core_configfs.c:
    target_core_drop_subdev() -> se_free_virtual_device() can happen via:
    
    	rmdir /sys/kernel/config/target/core/$HBA/*
    
    to release struct se_subsystem_dev in target_core_drop_subdev()
    
    Reported-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    Reported-by: default avatarFubo Chen <fubo.chen@gmail.com>
    Signed-off-by: default avatarNicholas A. Bellinger <nab@linux-iscsi.org>
    Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
    05aea6e7