Skip to content
  • Jan Beulich's avatar
    tools/hotplug: Linux udev rules adjustment · 08d1aa1b
    Jan Beulich authored
    
    
    While earlier this year some work was done to eliminate libxc's
    creation of nodes under /dev (as in some cases it actually got
    things wrong), I just found that tapdisk2 does exactly the same.
    While I'm not currently aiming at removing this code, I want to
    at least suggest some adjustments to the provided rules file.
    
    First of all, the present rule
    
    KERNEL=="blktap[0-9]*", NAME="xen/%k"
    
    matches both blktap1's devices and blktap2's ring devices,
    resulting in whoever comes last replacing what was there
    before (e.g. a tap2:aio: attach will replace bltap1's
    /dev/blktap0 [i.e. the main control device] with the ring device
    of the new virtual disk). Therefore we should add a subsystem
    qualifier there.
    
    Second, at some udev versions default to using 0660 as the
    permissions on nodes it creates. The kernel (with devtmpfs)
    defaults to 0600, and hence I'd suggest to also make this
    explicit in the rules.
    
    Signed-off-by: default avatarJan Beulich <jbeulich@novell.com>
    Cc: Boris Derzhavets <bderzhavets@yahoo.com>
    Signed-off-by: default avatarIan Jackson <ian.jackson@eu.citrix.com>
    08d1aa1b