Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • emulab-devel emulab-devel
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 164
    • Issues 164
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • emulabemulab
  • emulab-develemulab-devel
  • Merge requests
  • !66

fixed SLIVER_INFO time parsing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Wim Van de Meerssche requested to merge wvdemeer/emulab-devel:SLIVER_INFO-time-fix into master Jun 24, 2020
  • Overview 2
  • Commits 1
  • Changes 1

The original SLIVER_INFO code indirectly passed a datetime to mysql in RFC3339 format. That worked, on the old mysql version we were running.

But with a more recent mysql, things are more strict, and this doesn't work at all.

This fix uses POSIX::strftime("%Y-%m-%d %H:%M:%S", localtime(str2time($rfc3339_date_string))) to convert an RFC3339 date string to something that can be plugged directly into a mysql query. I hope that's correct? If there's a cleaner method, I'll change the code to that.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: SLIVER_INFO-time-fix